foreach copy-on-iterate: docs, roadmap, and tests #4

Merged

thesimonharms merged 3 commits from Milo/pic:milo/foreach-copy-docs-and-test into main

2026-10-14 05:54:12 -04:00

Milo commented

2026-10-13 19:12:08 -04:00

Contributor

Follow-up to the merged PR #3 ("foreach: clone array before iteration for copy-on-iterate semantics").

README.md: removed the now-false "Dialect: breaking changes" bullet claiming foreach walks the live array without copying first.
ROADMAP.md: marked the "Maybe later" item foreach copy-on-iterate as done ([x]), since PR #3 implemented it.
internal/compiler/compiler_test.go: added TestForeachCopyOnIterateAppend (appending inside foreach does not affect iteration: 3 iterations, 6 elements afterwards) and TestForeachCopyOnIterateUnset (unsetting an element inside foreach does not affect iteration: all three values 1, 2, 3 are visited), matching real PHP semantics.

Follow-up to the merged PR #3 ("foreach: clone array before iteration for copy-on-iterate semantics"). - README.md: removed the now-false "Dialect: breaking changes" bullet claiming `foreach` walks the live array without copying first. - ROADMAP.md: marked the "Maybe later" item `foreach` copy-on-iterate as done (`[x]`), since PR #3 implemented it. - internal/compiler/compiler_test.go: added `TestForeachCopyOnIterateAppend` (appending inside `foreach` does not affect iteration: 3 iterations, 6 elements afterwards) and `TestForeachCopyOnIterateUnset` (unsetting an element inside `foreach` does not affect iteration: all three values 1, 2, 3 are visited), matching real PHP semantics.

Milo added 3 commits

2026-10-13 19:12:09 -04:00

Remove stale foreach bullet from README 91798c80ea

PR #3 changed foreach to clone the array before iterating (copy-on-iterate, matching PHP), so the bullet claiming it walks the live array is now false.

Mark foreach copy-on-iterate done in ROADMAP c7934b99d8

Merged PR #3 implemented it, closing the Maybe later item.

Add foreach copy-on-iterate tests 681caccf65

Covers the PR #3 behavior: appending inside foreach does not affect iteration (3 iterations, 6 elements afterwards), and unsetting an element inside foreach does not affect iteration (all three values visited).