Add trait support to pic compiler #2

Open

jnana wants to merge 1 commit from jnana/choose-TraitSupport into main AGit

pull from: jnana/choose-TraitSupport

merge into: thesimonharms:main

thesimonharms:main

thesimonharms:jnana/harness-sessions

thesimonharms:jnana/node-sessions

Conversation 0 Commits 1 Files changed 3 +238 -774

jnana commented 2026-10-03 18:30:32 -04:00

Contributor

Copy link

Adds basic trait support including:

• TraitDecl, TraitUse, TraitAliasStmt AST types
• Trait token and keyword handling
• parseTrait(), parseMethodDecl(), parseParam() methods
• parseBlockStmt() fix

This enables PHP trait syntax for code reusability, one of the key compatibility features from the roadmap.

Adds basic trait support including: - TraitDecl, TraitUse, TraitAliasStmt AST types - Trait token and keyword handling - parseTrait(), parseMethodDecl(), parseParam() methods - parseBlockStmt() fix This enables PHP trait syntax for code reusability, one of the key compatibility features from the roadmap.

jnana added 1 commit 2026-10-03 18:30:32 -04:00

Add trait support to pic compiler ... 8629cc5d2f

Adds basic trait support including:
- TraitDecl, TraitUse, TraitAliasStmt AST types
- Trait token and keyword handling
- parseTrait(), parseMethodDecl(), parseParam() methods
- parseBlockStmt() fix

This enables PHP trait syntax for code reusability, one of the key compatibility features from the roadmap.

This pull request has changes conflicting with the target branch.

• internal/ast/ast.go
• internal/parser/parser.go

View command line instructions

Manual merge helper

Use this merge commit message when completing the merge manually.

Merge commit title Merge pull request 'Add trait support to pic compiler' (#2) from jnana/choose-TraitSupport into main

Merge commit body Reviewed-on: https://git.simonharms.com/thesimonharms/pic/pulls/2

Merge pull request 'Add trait support to pic compiler' (#2) from jnana/choose-TraitSupport into main Reviewed-on: https://git.simonharms.com/thesimonharms/pic/pulls/2 Copy merge commit message

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin +refs/pull/2/head:jnana/choose-TraitSupport

git switch jnana/choose-TraitSupport

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main

git merge --no-ff jnana/choose-TraitSupport

git switch jnana/choose-TraitSupport

git rebase main

git switch main

git merge --ff-only jnana/choose-TraitSupport

git switch jnana/choose-TraitSupport

git rebase main

git switch main

git merge --no-ff jnana/choose-TraitSupport

git switch main

git merge --squash jnana/choose-TraitSupport

git switch main

git merge --ff-only jnana/choose-TraitSupport

git switch main

git merge jnana/choose-TraitSupport

git push origin main

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

thesimonharms/pic!2

No description provided.